danolo
/
rss-bridge
mirror of https://github.com/danoloan10/rss-bridge
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[ItchioBridge] Remove reliance on in-page timestamps (#2127) 

This significantly increases the possibility of missing updates (if
files are uploaded but no file names or post contents are changed) and
of showing an update when there is none (if the post text is changed
but no new files are uploaded). However with the on-page timestamps
removed I'm not sure if there is a good way to do this more accurately
so this is good as we can do at the moment.
This commit is contained in:
Jacques Heunis 2021-05-30 19:12:19 +01:00 committed by GitHub
parent b074abcc0d
commit eec1163fb9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
bridges/ItchioBridge.php
View File

@ -20,8 +20,6 @@ class ItchioBridge extends BridgeAbstract {
or returnServerError('Could not request: ' . $url);
$title = $html->find('.game_title', 0)->innertext;
$timestampOriginal = $html->find('span.icon-stopwatch', 0)->parent()->title;
$timestampFormatted = str_replace('@', '', $timestampOriginal);
$content = 'The following files are available to download:<br/>';
foreach ($html->find('div.upload') as $element) {
@ -30,17 +28,20 @@ class ItchioBridge extends BridgeAbstract {
$content = $content . $filename . ' (' . $filesize . ')<br/>';
}
// NOTE: At the time of writing it is not clear under which conditions
// itch updates the timestamp. In case they don't always update it,
// we include the file list as well when computing the UID hash.
$uidContent = $timestampFormatted . $content;
// On 2021-04-28/29, itch.io changed their project page format so that the
// 'last updated' timestamp is only shown to logged-in users.
// Since we can't use the last-updated date to identify a post, we include
// the description text in the input for the UID hash so that if the
// project posts an update that changes the description but does not add
// or rename any files, we'll still flag it as an update.
$project_description = $html->find('div.formatted_description', 0)->plaintext;
$uidContent = $project_description . $content;
$item = array();
$item['uri'] = $url;
$item['uid'] = $uidContent;
$item['title'] = 'New release for ' . $title;
$item['title'] = 'Update for ' . $title;
$item['content'] = $content;
$item['timestamp'] = $timestampFormatted;
$this->items[] = $item;
}
}