From e0db349a579b466b9e7e9c7e96274d55af1fd67f Mon Sep 17 00:00:00 2001 From: logmanoriginal Date: Tue, 22 Jan 2019 18:24:32 +0100 Subject: [PATCH] bridges: Fix bridges that don't pass the unit test --- bridges/AllocineFRBridge.php | 1 - bridges/AmazonBridge.php | 2 -- bridges/AmazonPriceTrackerBridge.php | 1 - bridges/BundesbankBridge.php | 1 - bridges/ContainerLinuxReleasesBridge.php | 1 - bridges/DealabsBridge.php | 4 ---- bridges/DesoutterBridge.php | 3 --- bridges/ExtremeDownloadBridge.php | 1 - bridges/FDroidBridge.php | 1 - bridges/FeedExpanderExampleBridge.php | 1 - bridges/GBAtempBridge.php | 1 - bridges/HotUKDealsBridge.php | 4 ---- bridges/InstructablesBridge.php | 2 -- bridges/JustETFBridge.php | 1 - bridges/KununuBridge.php | 2 -- bridges/MangareaderBridge.php | 1 - bridges/MydealsBridge.php | 4 ---- bridges/NineGagBridge.php | 3 --- bridges/NotAlwaysBridge.php | 3 +-- bridges/OnVaSortirBridge.php | 1 - bridges/OpenClassroomsBridge.php | 1 - bridges/SkimfeedBridge.php | 2 -- bridges/WikiLeaksBridge.php | 2 -- bridges/WikipediaBridge.php | 2 -- 24 files changed, 1 insertion(+), 44 deletions(-) diff --git a/bridges/AllocineFRBridge.php b/bridges/AllocineFRBridge.php index 50a41ec7..17da9031 100644 --- a/bridges/AllocineFRBridge.php +++ b/bridges/AllocineFRBridge.php @@ -10,7 +10,6 @@ class AllocineFRBridge extends BridgeAbstract { 'category' => array( 'name' => 'category', 'type' => 'list', - 'required' => true, 'exampleValue' => 'Faux Raccord', 'title' => 'Select your category', 'values' => array( diff --git a/bridges/AmazonBridge.php b/bridges/AmazonBridge.php index c9d4dc9c..bcd83dcc 100644 --- a/bridges/AmazonBridge.php +++ b/bridges/AmazonBridge.php @@ -16,7 +16,6 @@ class AmazonBridge extends BridgeAbstract { 'sort' => array( 'name' => 'Sort by', 'type' => 'list', - 'required' => false, 'values' => array( 'Relevance' => 'relevanceblender', 'Price: Low to High' => 'price-asc-rank', @@ -29,7 +28,6 @@ class AmazonBridge extends BridgeAbstract { 'tld' => array( 'name' => 'Country', 'type' => 'list', - 'required' => true, 'values' => array( 'Australia' => 'com.au', 'Brazil' => 'com.br', diff --git a/bridges/AmazonPriceTrackerBridge.php b/bridges/AmazonPriceTrackerBridge.php index e31a03bb..6fa11c91 100644 --- a/bridges/AmazonPriceTrackerBridge.php +++ b/bridges/AmazonPriceTrackerBridge.php @@ -19,7 +19,6 @@ class AmazonPriceTrackerBridge extends BridgeAbstract { 'tld' => array( 'name' => 'Country', 'type' => 'list', - 'required' => true, 'values' => array( 'Australia' => 'com.au', 'Brazil' => 'com.br', diff --git a/bridges/BundesbankBridge.php b/bridges/BundesbankBridge.php index d21f22b6..b64a6425 100644 --- a/bridges/BundesbankBridge.php +++ b/bridges/BundesbankBridge.php @@ -17,7 +17,6 @@ class BundesbankBridge extends BridgeAbstract { self::PARAM_LANG => array( 'name' => 'Language', 'type' => 'list', - 'required' => true, 'defaultValue' => self::LANG_DE, 'values' => array( 'English' => self::LANG_EN, diff --git a/bridges/ContainerLinuxReleasesBridge.php b/bridges/ContainerLinuxReleasesBridge.php index ae438885..d2f63256 100644 --- a/bridges/ContainerLinuxReleasesBridge.php +++ b/bridges/ContainerLinuxReleasesBridge.php @@ -15,7 +15,6 @@ class ContainerLinuxReleasesBridge extends BridgeAbstract { 'channel' => [ 'name' => 'Release Channel', 'type' => 'list', - 'required' => true, 'defaultValue' => self::STABLE, 'values' => [ 'Stable' => self::STABLE, diff --git a/bridges/DealabsBridge.php b/bridges/DealabsBridge.php index 89183edb..3427ca65 100644 --- a/bridges/DealabsBridge.php +++ b/bridges/DealabsBridge.php @@ -15,13 +15,11 @@ class DealabsBridge extends PepperBridgeAbstract { 'hide_expired' => array( 'name' => 'Masquer les éléments expirés', 'type' => 'checkbox', - 'required' => true ), 'hide_local' => array( 'name' => 'Masquer les deals locaux', 'type' => 'checkbox', 'title' => 'Masquer les deals en magasins physiques', - 'required' => true ), 'priceFrom' => array( 'name' => 'Prix minimum', @@ -41,7 +39,6 @@ class DealabsBridge extends PepperBridgeAbstract { 'group' => array( 'name' => 'Groupe', 'type' => 'list', - 'required' => true, 'title' => 'Groupe dont il faut afficher les deals', 'values' => array( 'Abonnements internet' => 'abonnements-internet', @@ -957,7 +954,6 @@ class DealabsBridge extends PepperBridgeAbstract { 'order' => array( 'name' => 'Trier par', 'type' => 'list', - 'required' => true, 'title' => 'Ordre de tri des deals', 'values' => array( 'Du deal le plus Hot au moins Hot' => '', diff --git a/bridges/DesoutterBridge.php b/bridges/DesoutterBridge.php index 14e26c26..4a7b0a94 100644 --- a/bridges/DesoutterBridge.php +++ b/bridges/DesoutterBridge.php @@ -15,7 +15,6 @@ class DesoutterBridge extends BridgeAbstract { 'news_lang' => array( 'name' => 'Language', 'type' => 'list', - 'required' => true, 'title' => 'Select your language', 'defaultValue' => 'Corporate', 'values' => array( @@ -66,7 +65,6 @@ class DesoutterBridge extends BridgeAbstract { 'industry_lang' => array( 'name' => 'Language', 'type' => 'list', - 'required' => true, 'title' => 'Select your language', 'defaultValue' => 'Corporate', 'values' => array( @@ -117,7 +115,6 @@ class DesoutterBridge extends BridgeAbstract { 'full' => array( 'name' => 'Load full articles', 'type' => 'checkbox', - 'required' => false, 'title' => 'Enable to load the full article for each item' ) ) diff --git a/bridges/ExtremeDownloadBridge.php b/bridges/ExtremeDownloadBridge.php index 52729971..acdf6301 100644 --- a/bridges/ExtremeDownloadBridge.php +++ b/bridges/ExtremeDownloadBridge.php @@ -15,7 +15,6 @@ class ExtremeDownloadBridge extends BridgeAbstract { 'filter' => array( 'name' => 'Type de contenu', 'type' => 'list', - 'required' => true, 'title' => 'Type de contenu à suivre : Téléchargement, Streaming ou les deux', 'values' => array( 'Streaming et Téléchargement' => 'both', diff --git a/bridges/FDroidBridge.php b/bridges/FDroidBridge.php index b606cec1..65a1a9f2 100644 --- a/bridges/FDroidBridge.php +++ b/bridges/FDroidBridge.php @@ -11,7 +11,6 @@ class FDroidBridge extends BridgeAbstract { 'u' => array( 'name' => 'Widget selection', 'type' => 'list', - 'required' => true, 'values' => array( 'Latest added apps' => 'added', 'Latest updated apps' => 'updated' diff --git a/bridges/FeedExpanderExampleBridge.php b/bridges/FeedExpanderExampleBridge.php index 537a6352..f5b83071 100644 --- a/bridges/FeedExpanderExampleBridge.php +++ b/bridges/FeedExpanderExampleBridge.php @@ -11,7 +11,6 @@ class FeedExpanderExampleBridge extends FeedExpander { 'version' => array( 'name' => 'Version', 'type' => 'list', - 'required' => true, 'title' => 'Select your feed format/version', 'defaultValue' => 'RSS 2.0', 'values' => array( diff --git a/bridges/GBAtempBridge.php b/bridges/GBAtempBridge.php index 9383be76..48a7f851 100644 --- a/bridges/GBAtempBridge.php +++ b/bridges/GBAtempBridge.php @@ -10,7 +10,6 @@ class GBAtempBridge extends BridgeAbstract { 'type' => array( 'name' => 'Type', 'type' => 'list', - 'required' => true, 'values' => array( 'News' => 'N', 'Reviews' => 'R', diff --git a/bridges/HotUKDealsBridge.php b/bridges/HotUKDealsBridge.php index 8c1b3bd1..ed2d28af 100644 --- a/bridges/HotUKDealsBridge.php +++ b/bridges/HotUKDealsBridge.php @@ -17,13 +17,11 @@ class HotUKDealsBridge extends PepperBridgeAbstract { 'hide_expired' => array( 'name' => 'Hide expired deals', 'type' => 'checkbox', - 'required' => true ), 'hide_local' => array( 'name' => 'Hide local deals', 'type' => 'checkbox', 'title' => 'Hide deals in physical store', - 'required' => true ), 'priceFrom' => array( 'name' => 'Minimal Price', @@ -43,7 +41,6 @@ class HotUKDealsBridge extends PepperBridgeAbstract { 'group' => array( 'name' => 'Group', 'type' => 'list', - 'required' => true, 'title' => 'Group whose deals must be displayed', 'values' => array( '2DS' => '2ds', @@ -1317,7 +1314,6 @@ class HotUKDealsBridge extends PepperBridgeAbstract { 'order' => array( 'name' => 'Order by', 'type' => 'list', - 'required' => true, 'title' => 'Sort order of deals', 'values' => array( 'From the most to the least hot deal' => '-hot', diff --git a/bridges/InstructablesBridge.php b/bridges/InstructablesBridge.php index 05f1a91c..7e7d5428 100644 --- a/bridges/InstructablesBridge.php +++ b/bridges/InstructablesBridge.php @@ -21,7 +21,6 @@ class InstructablesBridge extends BridgeAbstract { 'category' => array( 'name' => 'Category', 'type' => 'list', - 'required' => true, 'values' => array( 'Play' => array( 'All' => '/play/', @@ -240,7 +239,6 @@ class InstructablesBridge extends BridgeAbstract { 'filter' => array( 'name' => 'Filter', 'type' => 'list', - 'required' => true, 'values' => array( 'Featured' => ' ', 'Recent' => 'recent/', diff --git a/bridges/JustETFBridge.php b/bridges/JustETFBridge.php index 85318b8e..8d5b3d5a 100644 --- a/bridges/JustETFBridge.php +++ b/bridges/JustETFBridge.php @@ -34,7 +34,6 @@ class JustETFBridge extends BridgeAbstract { 'global' => array( 'lang' => array( 'name' => 'Language', - 'required' => true, 'type' => 'list', 'values' => array( 'Englisch' => 'en', diff --git a/bridges/KununuBridge.php b/bridges/KununuBridge.php index 2f4bf0b2..cb13ca35 100644 --- a/bridges/KununuBridge.php +++ b/bridges/KununuBridge.php @@ -11,7 +11,6 @@ class KununuBridge extends BridgeAbstract { 'site' => array( 'name' => 'Site', 'type' => 'list', - 'required' => true, 'title' => 'Select your site', 'values' => array( 'Austria' => 'at', @@ -23,7 +22,6 @@ class KununuBridge extends BridgeAbstract { 'full' => array( 'name' => 'Load full article', 'type' => 'checkbox', - 'required' => false, 'exampleValue' => 'checked', 'title' => 'Activate to load full article' ) diff --git a/bridges/MangareaderBridge.php b/bridges/MangareaderBridge.php index 91537069..9ecb0feb 100644 --- a/bridges/MangareaderBridge.php +++ b/bridges/MangareaderBridge.php @@ -13,7 +13,6 @@ class MangareaderBridge extends BridgeAbstract { 'category' => array( 'name' => 'Category', 'type' => 'list', - 'required' => true, 'values' => array( 'All' => 'all', 'Action' => 'action', diff --git a/bridges/MydealsBridge.php b/bridges/MydealsBridge.php index aa5bb489..603f4e07 100644 --- a/bridges/MydealsBridge.php +++ b/bridges/MydealsBridge.php @@ -17,13 +17,11 @@ class MydealsBridge extends PepperBridgeAbstract { 'hide_expired' => array( 'name' => 'Abgelaufenes ausblenden', 'type' => 'checkbox', - 'required' => true ), 'hide_local' => array( 'name' => 'Lokales ausblenden', 'type' => 'checkbox', 'title' => 'Deals im physischen Geschäft ausblenden', - 'required' => true ), 'priceFrom' => array( 'name' => 'Minimaler Preis', @@ -43,7 +41,6 @@ class MydealsBridge extends PepperBridgeAbstract { 'group' => array( 'name' => 'Gruppen', 'type' => 'list', - 'required' => true, 'title' => 'Gruppe, deren Deals angezeigt werden müssen', 'values' => array( 'Elektronik' => 'elektronik', @@ -66,7 +63,6 @@ class MydealsBridge extends PepperBridgeAbstract { 'order' => array( 'name' => 'sortieren nach', 'type' => 'list', - 'required' => true, 'title' => 'Sortierung der deals', 'values' => array( 'Vom heißesten zum kältesten Deal' => '', diff --git a/bridges/NineGagBridge.php b/bridges/NineGagBridge.php index f5261356..e726c732 100644 --- a/bridges/NineGagBridge.php +++ b/bridges/NineGagBridge.php @@ -11,7 +11,6 @@ class NineGagBridge extends BridgeAbstract { 'd' => array( 'name' => 'Section', 'type' => 'list', - 'required' => true, 'values' => array( 'Hot' => 'hot', 'Trending' => 'trending', @@ -28,7 +27,6 @@ class NineGagBridge extends BridgeAbstract { 'g' => array( 'name' => 'Section', 'type' => 'list', - 'required' => true, 'values' => array( 'Animals' => 'cute', 'Anime & Manga' => 'anime-manga', @@ -88,7 +86,6 @@ class NineGagBridge extends BridgeAbstract { 't' => array( 'name' => 'Type', 'type' => 'list', - 'required' => true, 'values' => array( 'Hot' => 'hot', 'Fresh' => 'fresh', diff --git a/bridges/NotAlwaysBridge.php b/bridges/NotAlwaysBridge.php index b2f4c35a..c7758c32 100644 --- a/bridges/NotAlwaysBridge.php +++ b/bridges/NotAlwaysBridge.php @@ -21,8 +21,7 @@ class NotAlwaysBridge extends BridgeAbstract { 'Friendly' => 'friendly', 'Hopeless' => 'hopeless', 'Unfiltered' => 'unfiltered' - ), - 'required' => true + ) ) )); diff --git a/bridges/OnVaSortirBridge.php b/bridges/OnVaSortirBridge.php index ee6baf19..ed1dcb65 100644 --- a/bridges/OnVaSortirBridge.php +++ b/bridges/OnVaSortirBridge.php @@ -9,7 +9,6 @@ class OnVaSortirBridge extends FeedExpander { 'city' => array( 'name' => 'City', 'type' => 'list', - 'required' => true, 'values' => array( 'Agen' => 'Agen', 'Ajaccio' => 'Ajaccio', diff --git a/bridges/OpenClassroomsBridge.php b/bridges/OpenClassroomsBridge.php index 5f0daca4..4db7bc19 100644 --- a/bridges/OpenClassroomsBridge.php +++ b/bridges/OpenClassroomsBridge.php @@ -11,7 +11,6 @@ class OpenClassroomsBridge extends BridgeAbstract { 'u' => array( 'name' => 'Catégorie', 'type' => 'list', - 'required' => true, 'values' => array( 'Arts & Culture' => 'arts', 'Code' => 'code', diff --git a/bridges/SkimfeedBridge.php b/bridges/SkimfeedBridge.php index 9fdd4549..1b78baf2 100644 --- a/bridges/SkimfeedBridge.php +++ b/bridges/SkimfeedBridge.php @@ -18,7 +18,6 @@ class SkimfeedBridge extends BridgeAbstract { 'box_channel' => array( 'name' => 'Channel', 'type' => 'list', - 'required' => true, 'title' => 'Select your channel', 'values' => array( 'Hacker News' => '/news/hacker-news.html', @@ -68,7 +67,6 @@ class SkimfeedBridge extends BridgeAbstract { 'tech_channel' => array( 'name' => 'Tech channel', 'type' => 'list', - 'required' => true, 'title' => 'Select your tech channel', 'values' => array( 'Agg' => array( diff --git a/bridges/WikiLeaksBridge.php b/bridges/WikiLeaksBridge.php index c5b9bb69..363cf0c0 100644 --- a/bridges/WikiLeaksBridge.php +++ b/bridges/WikiLeaksBridge.php @@ -9,7 +9,6 @@ class WikiLeaksBridge extends BridgeAbstract { 'category' => array( 'name' => 'Category', 'type' => 'list', - 'required' => true, 'title' => 'Select your category', 'values' => array( 'News' => '-News-', @@ -28,7 +27,6 @@ class WikiLeaksBridge extends BridgeAbstract { 'teaser' => array( 'name' => 'Show teaser', 'type' => 'checkbox', - 'required' => false, 'title' => 'If checked feeds will display the teaser', 'defaultValue' => true ) diff --git a/bridges/WikipediaBridge.php b/bridges/WikipediaBridge.php index 6b534407..7ca763fc 100644 --- a/bridges/WikipediaBridge.php +++ b/bridges/WikipediaBridge.php @@ -13,7 +13,6 @@ class WikipediaBridge extends BridgeAbstract { 'language' => array( 'name' => 'Language', 'type' => 'list', - 'required' => true, 'title' => 'Select your language', 'exampleValue' => 'English', 'values' => array( @@ -27,7 +26,6 @@ class WikipediaBridge extends BridgeAbstract { 'subject' => array( 'name' => 'Subject', 'type' => 'list', - 'required' => true, 'title' => 'What subject are you interested in?', 'exampleValue' => 'Today\'s featured article', 'values' => array(