From d8f5aa3c795b4a8996507a7cbe62ef13ba802ce0 Mon Sep 17 00:00:00 2001
From: logmanoriginal <logmanoriginal@users.noreply.github.com>
Date: Tue, 14 Feb 2017 17:00:22 +0100
Subject: [PATCH] [phpcs] Add sniffs for function declaration and -calls

When declaring a function
- Do not add a space before a comma
- Add a space after a comma
- Add a space after an equal sign

Example:
function myFunction($x, $y, $z = null){...}

When calling a function
- Do not add a space before the opening parenthesis
- Do not add a space after the opening parenthesis
- Do not add a space before the closing parenthesis
- Do not add a space before a comma
- Add a space after a comma

Example:
myFunction('x', 'y', 'z');
---
 phpcs.xml | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/phpcs.xml b/phpcs.xml
index cd0b050c..65e3a5a4 100644
--- a/phpcs.xml
+++ b/phpcs.xml
@@ -21,6 +21,13 @@
       <property name="absoluteLineLimit" value="120"/>
     </properties>
   </rule>
+  <!-- When calling a function: -->
+  <!-- Do not add a space before the opening parenthesis -->
+  <!-- Do not add a space after the opening parenthesis -->
+  <!-- Do not add a space before the closing parenthesis -->
+  <!-- Do not add a space before a comma -->
+  <!-- Add a space after a comma -->
+  <rule ref="Generic.Functions.FunctionCallArgumentSpacing"/>
   <!-- Use UPPERCARE for constants -->
   <rule ref="Generic.NamingConventions.UpperCaseConstantName"/>
   <!-- Use lowercase for 'true', 'false' and 'null' -->
@@ -37,6 +44,15 @@
   <rule ref="PSR2.ControlStructures.ElseIfDeclaration"/>
   <!-- Add a new line at the end of a file -->
   <rule ref="PSR2.Files.EndFileNewline"/>
+  <!-- When declaring a function: -->
+  <!-- Do not add a space before a comma -->
+  <!-- Add a space after a comma -->
+  <!-- Add a space before and after an equal sign -->
+  <rule ref="Squiz.Functions.FunctionDeclarationArgumentSpacing">
+    <properties>
+      <property name="equalsSpacing" value="1"/>
+    </properties>
+  </rule>
   <!-- Do not add spaces when casting -->
   <rule ref="Squiz.WhiteSpace.CastSpacing"/>
   <!-- Operators must have a space around them -->