danolo
/
rss-bridge
mirror of https://github.com/danoloan10/rss-bridge
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[html] improve srcset attribute parsing (#3769) 

Fix commas not being used for splitting, resulting in broken src URL in some cases:
srcset="url1.jpg, url2.jpg 2x" would give src="url1.jpg,"
This commit is contained in:
ORelio 2023-10-18 19:12:19 +02:00 committed by GitHub
parent a41bb088f8
commit 7533ef12e3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
lib/html.php
View File

@ -244,16 +244,26 @@ function convertLazyLoading($dom)
$dom = str_get_html($dom); $dom = str_get_html($dom);
} }
// Retrieve image URL from srcset attribute
// https://developer.mozilla.org/en-US/docs/Web/API/HTMLImageElement/srcset
// Example: convert "header640.png 640w, header960.png 960w, header1024.png 1024w" to "header1024.png"
$srcset_to_src = function ($srcset) {
$sources = explode(',', $srcset);
$last_entry = trim(end($sources));
$url = explode(' ', $last_entry)[0];
return $url;
};
// Process standalone images, embeds and picture sources // Process standalone images, embeds and picture sources
foreach ($dom->find('img, iframe, source') as $img) { foreach ($dom->find('img, iframe, source') as $img) {
if (!empty($img->getAttribute('data-src'))) { if (!empty($img->getAttribute('data-src'))) {
$img->src = $img->getAttribute('data-src'); $img->src = $img->getAttribute('data-src');
} elseif (!empty($img->getAttribute('data-srcset'))) { } elseif (!empty($img->getAttribute('data-srcset'))) {
$img->src = explode(' ', $img->getAttribute('data-srcset'))[0]; $img->src = $srcset_to_src($img->getAttribute('data-srcset'));
} elseif (!empty($img->getAttribute('data-lazy-src'))) { } elseif (!empty($img->getAttribute('data-lazy-src'))) {
$img->src = $img->getAttribute('data-lazy-src'); $img->src = $img->getAttribute('data-lazy-src');
} elseif (!empty($img->getAttribute('srcset'))) { } elseif (!empty($img->getAttribute('srcset'))) {
$img->src = explode(' ', $img->getAttribute('srcset'))[0]; $img->src = $srcset_to_src($img->getAttribute('srcset'));
} else { } else {
continue; // Proceed to next element without removing attributes continue; // Proceed to next element without removing attributes
} }